[Intel-wired-lan] [PATCH S38 06/15] ice: Add support to enable/disable all Rx queues before waiting
Bowers, AndrewX
andrewx.bowers at intel.com
Mon Jan 27 23:14:20 UTC 2020
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Wednesday, January 22, 2020 7:21 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S38 06/15] ice: Add support to
> enable/disable all Rx queues before waiting
>
> From: Brett Creeley <brett.creeley at intel.com>
>
> Currently when we enable/disable all Rx queues we do the following
> sequence for each Rx queue and then move to the next queue.
>
> 1. Enable/Disable the Rx queue via register write.
> 2. Read the configuration register to determine if the Rx queue was
> enabled/disabled successfully.
>
> In some cases enabling/disabling queue 0 fails because of step 2 above.
> Fix this by doing step 1 for all of the Rx queues and then step 2 for all of the
> Rx queues.
>
> Also, there are cases where we enable/disable a single queue (i.e.
> SR-IOV and XDP) so add a new function that does step 1 and 2 above with a
> read flush in between.
>
> This change also required a single Rx queue to be enabled/disabled with and
> without waiting for the change to propagate through hardware. Fix this by
> adding a boolean wait flag to the necessary functions.
>
> Also, add the keywords "one" and "all" to distinguish between
> enabling/disabling a single Rx queue and all Rx queues respectively.
>
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_base.c | 42 ++++++++++++++-----
> drivers/net/ethernet/intel/ice/ice_base.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 +-
> drivers/net/ethernet/intel/ice/ice_lib.c | 32 +++++++++-----
> drivers/net/ethernet/intel/ice/ice_lib.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 4 +-
> .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 7 ++--
> drivers/net/ethernet/intel/ice/ice_xsk.c | 4 +-
> 8 files changed, 67 insertions(+), 34 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan
mailing list