[Intel-wired-lan] [PATCH net] ice: Fix a couple off by one bugs
Dan Carpenter
dan.carpenter at oracle.com
Fri Jan 31 04:56:59 UTC 2020
The hw->blk[blk]->es.ref_count[] array has hw->blk[blk].es.count
elements. It gets allocated in ice_init_hw_tbls(). So the > should be
>= to prevent accessing one element beyond the end of the array.
Fixes: 2c61054c5fda ("ice: Optimize table usage")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
index 99208946224c..38a7041fe774 100644
--- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
+++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c
@@ -1950,7 +1950,7 @@ ice_free_prof_id(struct ice_hw *hw, enum ice_block blk, u8 prof_id)
static enum ice_status
ice_prof_inc_ref(struct ice_hw *hw, enum ice_block blk, u8 prof_id)
{
- if (prof_id > hw->blk[blk].es.count)
+ if (prof_id >= hw->blk[blk].es.count)
return ICE_ERR_PARAM;
hw->blk[blk].es.ref_count[prof_id]++;
@@ -1991,7 +1991,7 @@ ice_write_es(struct ice_hw *hw, enum ice_block blk, u8 prof_id,
static enum ice_status
ice_prof_dec_ref(struct ice_hw *hw, enum ice_block blk, u8 prof_id)
{
- if (prof_id > hw->blk[blk].es.count)
+ if (prof_id >= hw->blk[blk].es.count)
return ICE_ERR_PARAM;
if (hw->blk[blk].es.ref_count[prof_id] > 0) {
--
2.11.0
More information about the Intel-wired-lan
mailing list