[Intel-wired-lan] [PATCH S37 v3 08/15] ice: fix and consolidate logging of NVM/firmware version information

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Thursday, February 6, 2020 1:20 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S37 v3 08/15] ice: fix and consolidate
> logging of NVM/firmware version information
> 
> From: Bruce Allan <bruce.w.allan at intel.com>
> 
> Logging the firmware/NVM information during driver load is redundant since
> that information is also available via ethtool.  Move the functionality found in
> ice_nvm_version_str() directly into ice_get_drvinfo() and remove calling the
> former and logging that info during driver probe.  This also gets rid of a bug in
> ice_nvm_version_str() where it returns a pointer to a buffer which is free'ed
> when that function exits.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 15 +++++++++++++--
>  drivers/net/ethernet/intel/ice/ice_lib.c     | 19 -------------------
>  drivers/net/ethernet/intel/ice/ice_lib.h     |  2 --
>  drivers/net/ethernet/intel/ice/ice_main.c    |  5 -----
>  4 files changed, 13 insertions(+), 28 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>