[Intel-wired-lan] [next-queue PATCH v2 1/2] igc: Add support for taprio offloading

Andre Guedes andre.guedes at linux.intel.com
Mon Feb 10 20:33:59 UTC 2020


Hi Vinicius,

Quoting Vinicius Costa Gomes (2020-02-07 10:24:42)
...
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
...
> +/* Transmit Scheduling */
> +#define IGC_TQAVCTRL_TRANSMIT_MODE_TSN 0x00000001
> +#define IGC_TQAVCTRL_ENHANCED_QAV      0x00000008
> +
> +#define IGC_TXQCTL_STRICT_CYCLE                0x00000002
> +#define IGC_TXQCTL_STRICT_END          0x00000004
> +#define IGC_TXQCTL_PREEMPTIBLE         0x00000008

It seems you missed removing IGC_TXQCTL_PREEMPTIBLE here. This macro is not
used anywhere in the code.

> --- /dev/null
> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c)  2018 Intel Corporation */

s/2018/2020 ?

Regards,

Andre


More information about the Intel-wired-lan mailing list