[Intel-wired-lan] [PATCH v2] igc: add support to interrupt, eeprom, registers and link self-tests
Andre Guedes
andre.guedes at linux.intel.com
Thu Mar 19 21:59:12 UTC 2020
Hi Vitaly,
Quoting Vitaly Lifshits (2020-03-18 06:54:46)
> +u64 igc_link_test(struct igc_adapter *adapter, u64 *data)
> +{
> + bool link_up = false;
No need to initialize this variable since it is not read anywhere before
assignment in the end of this function.
> +
> + if (IGC_REMOVED(adapter->hw.hw_addr)) {
> + *data = 1;
> + return 1;
> + }
> + *data = 0;
> +
> + /* add delay to give enough time for autonegotioation to finish */
> + if (adapter->hw.mac.autoneg)
> + ssleep(5);
> +
> + link_up = igc_has_link(adapter);
> + if (!link_up)
> + *data = 1;
> +
> + return *data;
> +}
Regards,
Andre
More information about the Intel-wired-lan
mailing list