[Intel-wired-lan] [PATCH v2 4/4] igc: Refactor VLAN priority filtering code

Brown, Aaron F aaron.f.brown at intel.com
Fri May 1 21:47:51 UTC 2020


> From: Guedes, Andre <andre.guedes at intel.com>
> Sent: Thursday, April 23, 2020 6:11 PM
> To: intel-wired-lan at lists.osuosl.org; Brown, Aaron F
> <aaron.f.brown at intel.com>; Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>
> Subject: [PATCH v2 4/4] igc: Refactor VLAN priority filtering code
> 
> The whole VLAN priority filtering code is implemented in igc_ethtool.c
> and mixes logic from ethtool and core parts. This patch refactors it so
> core logic is moved to igc_main.c, aligning the VLAN priority filtering
> code organization with the MAC address filtering code.
> 
> This patch also takes the opportunity to add some log messages to ease
> debugging.
> 
> Signed-off-by: Andre Guedes <andre.guedes at intel.com>
> ---
> v2: Previous version had a bug when clearing IGC_VLANPQF_QSEL bits in
>     igc_del_vlan_prio_filter().
> ---
>  drivers/net/ethernet/intel/igc/igc.h         |  3 +
>  drivers/net/ethernet/intel/igc/igc_ethtool.c | 64 ++++----------------
>  drivers/net/ethernet/intel/igc/igc_main.c    | 52 ++++++++++++++++
>  3 files changed, 68 insertions(+), 51 deletions(-)
> 

Tested-by: Aaron Brown <aaron.f.brown at intel.com>



More information about the Intel-wired-lan mailing list