[Intel-wired-lan] [PATCH 16/19] igc: Fix NFC rule validation
Brown, Aaron F
aaron.f.brown at intel.com
Fri May 1 22:47:42 UTC 2020
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Andre Guedes
> Sent: Friday, April 24, 2020 1:16 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH 16/19] igc: Fix NFC rule validation
> If we try to overwrite an existing rule with the same filter but
> different action, we get EEXIST error as shown below.
> $ ethtool -N eth0 flow-type ether dst <MACADDR> action 1 loc 10
> $ ethtool -N eth0 flow-type ether dst <MACADDR> action 2 loc 10
> rmgr: Cannot insert RX class rule: File exists
> The second command is expected to overwrite the previous rule in location
> 10 and succeed.
> This patch fixes igc_ethtool_check_nfc_rule() so it also checks the
> rules location. In case they match, the rule under evaluation should not
> be considered invalid.
> Signed-off-by: Andre Guedes <andre.guedes at intel.com>
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown at intel.com>
More information about the Intel-wired-lan