[Intel-wired-lan] [PATCH] e1000e: Disable TSO for buffer overrun workaround

Brown, Aaron F aaron.f.brown at intel.com
Thu May 21 07:18:28 UTC 2020


> From: netdev-owner at vger.kernel.org <netdev-owner at vger.kernel.org> On
> Behalf Of Kai-Heng Feng
> Sent: Thursday, May 7, 2020 7:21 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>
> Cc: Kai-Heng Feng <kai.heng.feng at canonical.com>; David S. Miller
> <davem at davemloft.net>; Neftin, Sasha <sasha.neftin at intel.com>; Dima
> Ruinskiy <dima.ruinskiy at intel.com>; Avargil, Raanan
> <raanan.avargil at intel.com>; moderated list:INTEL ETHERNET DRIVERS <intel-
> wired-lan at lists.osuosl.org>; open list:NETWORKING DRIVERS
> <netdev at vger.kernel.org>; open list <linux-kernel at vger.kernel.org>
> Subject: [PATCH] e1000e: Disable TSO for buffer overrun workaround
> 
> Commit b10effb92e27 ("e1000e: fix buffer overrun while the I219 is
> processing DMA transactions") imposes roughly 30% performance penalty.
> 
> The commit log states that "Disabling TSO eliminates performance loss
> for TCP traffic without a noticeable impact on CPU performance", so
> let's disable TSO by default to regain the loss.
> 
> Fixes: b10effb92e27 ("e1000e: fix buffer overrun while the I219 is processing
> DMA transactions")
> BugLink: https://bugs.launchpad.net/bugs/1802691
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++++
>  1 file changed, 4 insertions(+)
Tested-by: Aaron Brown <aaron.f.brown at intel.com>



More information about the Intel-wired-lan mailing list