[Intel-wired-lan] [PATCH S43 04/15] ice: Check if unicast MAC exists before setting VF MAC
Bowers, AndrewX
andrewx.bowers at intel.com
Fri May 22 19:30:33 UTC 2020
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Friday, May 15, 2020 5:37 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S43 04/15] ice: Check if unicast MAC exists
> before setting VF MAC
>
> From: Brett Creeley <brett.creeley at intel.com>
>
> Currently if a unicast MAC is set via ndo_set_vf_mac, the PF driver will set
> the VF's dflt_lan_addr.addr once some basic checks have passed. The VF is
> then reset. During reset the PF driver will attempt to program the VF's MAC
> from the dflt_lan_addr.addr field. This fails when the MAC already exists on
> the PF's switch.
>
> This is causing the VF to be completely disabled until removing/enabling any
> VFs via sysfs.
>
> Fix this by checking if the unicast MAC exists before triggering a VF reset
> directly in ndo_set_vf_mac. Also, add a check if the unicast MAC is set to the
> same value as before and return 0 if that is the case.
>
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> ---
> .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan
mailing list