[Intel-wired-lan] [PATCH S44 12/14] ice: fix potential double free in probe unrolling

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Friday, May 15, 2020 5:42 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S44 12/14] ice: fix potential double free in
> probe unrolling
> 
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> If ice_init_interrupt_scheme fails, ice_probe will jump to clearing up the
> interrupts. This can lead to some static analysis tools such as the compiler
> sanitizers complaining about double free problems.
> 
> Since ice_init_interrupt_scheme already unrolls internally on failure, there is
> no need to call ice_clear_interrupt_scheme when it fails. Add a new unroll
> label and use that instead.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>