[Intel-wired-lan] Is it just me? next-queue_dev-queue Compile problems with ice as a module.

[Kirsher, Jeffrey T]

All is fixed up now...  I had to drop patch 9 of S44 of the ice driver, there was no easy solution with the recent kernel changes.

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Kirsher, Jeffrey T
> Sent: Wednesday, May 27, 2020 15:30
> To: Brown, Aaron F <aaron.f.brown at intel.com>; intel-wired-lan at osuosl.org
> Subject: Re: [Intel-wired-lan] Is it just me? next-queue_dev-queue Compile
> problems with ice as a module.
> 
> Nope it is not just you.  I have been working on fixing it since last night.  The
> XDP changes from Bjorn is what caused all these issues.  I just have it all fixed
> up here in the next hour.
> 
> > -----Original Message-----
> > From: Brown, Aaron F <aaron.f.brown at intel.com>
> > Sent: Wednesday, May 27, 2020 15:07
> > To: intel-wired-lan at osuosl.org
> > Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>
> > Subject: Is it just me? next-queue_dev-queue Compile problems with ice
> > as a module.
> >
> > Hi all,
> >
> > I'm getting a compile failure on a fresh pull of next-queue_dev-queue
> > if I try to build a kernel with the ice driver included as a module.
> > It builds fine when I checkout master branch and build or if I de-select
> CONFIG_ICE in the .config.
> > The failure I get is as follows:
> > -----------------------------------------------
> >   AR      net/core/built-in.a
> >   AR      net/built-in.a
> > u1519:[2]/usr/src/kernels/next-queue> cat err_make.log
> > drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_vsi_cfg_rxq':
> > drivers/net/ethernet/intel/ice/ice_base.c:410:37: error: 'struct
> > xdp_umem' has no member named 'chunk_size_nohr'
> >     ring->rx_buf_len = ring->xsk_umem->chunk_size_nohr -
> >                                      ^
> > drivers/net/ethernet/intel/ice/ice_base.c:412:8: error: 'struct
> > ice_ring' has no member named 'zca'
> >     ring->zca.free = ice_zca_free;
> >         ^
> > drivers/net/ethernet/intel/ice/ice_base.c:412:21: error:
> > 'ice_zca_free' undeclared (first use in this function)
> >     ring->zca.free = ice_zca_free;
> >                      ^
> > drivers/net/ethernet/intel/ice/ice_base.c:412:21: note: each
> > undeclared identifier is reported only once for each function it
> > appears in
> > drivers/net/ethernet/intel/ice/ice_base.c:414:9: error:
> 'MEM_TYPE_ZERO_COPY'
> > undeclared (first use in this function)
> >          MEM_TYPE_ZERO_COPY,
> >          ^
> > drivers/net/ethernet/intel/ice/ice_base.c:415:14: error: 'struct
> > ice_ring' has no member named 'zca'
> >          &ring->zca);
> >               ^
> > drivers/net/ethernet/intel/ice/ice_base.c:422:8: error: 'struct
> > ice_ring' has no member named 'zca'
> >     ring->zca.free = NULL;
> >         ^
> > drivers/net/ethernet/intel/ice/ice_base.c:445:3: error: implicit
> > declaration of function 'xsk_umem_has_addrs_rq' [-Werror=implicit-function-
> declaration]
> >    if (!xsk_umem_has_addrs_rq(ring->xsk_umem, num_bufs)) {
> >    ^
> > cc1: some warnings being treated as errors
> > make[6]: *** [drivers/net/ethernet/intel/ice/ice_base.o] Error 1
> > make[6]: *** Waiting for unfinished jobs....
> > make[5]: *** [drivers/net/ethernet/intel/ice] Error 2
> > make[4]: *** [drivers/net/ethernet/intel] Error 2
> > make[3]: *** [drivers/net/ethernet] Error 2
> > make[2]: *** [drivers/net] Error 2
> > make[1]: *** [drivers] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [sub-make] Error 2
> > u1519:[2]/usr/src/kernels/next-queue>
> > -----------------------------------------------
> > I bisected it down to this patch or one on either side:
> > 714c21f ice: Check UMEM FQ size when allocating bufs I am not exactly
> > sure as I had 0 steps left when I got here, but received a different
> > message on compile
> > instead:
> > u1519:[2]/usr/src/kernels/next-queue> cat err_make.log
> > drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_setup_rx_ctx':
> > drivers/net/ethernet/intel/ice/ice_base.c:432:3: error: implicit
> > declaration of function 'xsk_umem_has_addrs_rq' [-Werror=implicit-function-
> declaration]
> >    if (!xsk_umem_has_addrs_rq(ring->xsk_umem, num_bufs)) {
> >    ^
> > cc1: some warnings being treated as errors
> > make[6]: *** [drivers/net/ethernet/intel/ice/ice_base.o] Error 1
> > make[5]: *** [drivers/net/ethernet/intel/ice] Error 2
> > make[4]: *** [drivers/net/ethernet/intel] Error 2
> > make[3]: *** [drivers/net/ethernet] Error 2
> > make[2]: *** [drivers/net] Error 2
> > make[1]: *** [drivers] Error 2
> > make: *** [sub-make] Error 2
> > u1519:[2]/usr/src/kernels/next-queue>
> >
> > I'm using a relatively minimal kernel so could easily be missing
> > something that gets defined elsewhere.
> >
> 
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan