[Intel-wired-lan] [PATCH S46 3/9] ice: Fix inability to set channels when down
Bowers, AndrewX
andrewx.bowers at intel.com
Thu May 28 23:18:28 UTC 2020
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Friday, May 15, 2020 5:55 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S46 3/9] ice: Fix inability to set channels
> when down
>
> From: Jesse Brandeburg <jesse.brandeburg at intel.com>
>
> Currently the driver prevents a user from doing modprobe ice ethtool -L eth0
> combined 5 ip link set eth0 up
>
> The ethtool command fails, because the driver is checking to see if the
> interface is down before allowing the get_channels to proceed (even for a
> set_channels).
>
> Remove this check and allow the user to configure the interface before
> bringing it up, which is a much better usability case.
>
> Fixes: 87324e747fde ("ice: Implement ethtool ops for channels")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg at intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 ----
> 1 file changed, 4 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan
mailing list