[Intel-wired-lan] [PATCH v1 1/1] igc: Refactor the igc_power_up_link()

[Paul Menzel]

Dear Sasha,


Thank you for the patch.

Am 10.06.20 um 08:12 schrieb Sasha Neftin:
> PHY of the i225 device support only copper mode.
> There is no point to check media type in the
> igc_power_up_link() method.

One nit regarding the commit message summary. *Refactor* very generic. 
Could you use something like:

 > igc: Remove unneeded check for copper media type

> Signed-off-by: Sasha Neftin <sasha.neftin at intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index af5e1686f7f2..83c94fa58c40 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -115,8 +115,7 @@ static void igc_power_up_link(struct igc_adapter *adapter)
>   {
>   	igc_reset_phy(&adapter->hw);
>   
> -	if (adapter->hw.phy.media_type == igc_media_type_copper)
> -		igc_power_up_phy_copper(&adapter->hw);
> +	igc_power_up_phy_copper(&adapter->hw);
>   
>   	igc_setup_link(&adapter->hw);
>   }

Reviewed-by: Paul Menzel <pmenzel at molgen.mpg.de>


Kind regards,

Paul