[Intel-wired-lan] [PATCH net] i40e: fix crash when Rx descriptor count is changed

Bowers, AndrewX andrewx.bowers at intel.com
Thu Jun 18 19:46:09 UTC 2020


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Björn Töpel
> Sent: Friday, June 12, 2020 4:48 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org; bpf at vger.kernel.org; Topel, Bjorn
> <bjorn.topel at intel.com>; Karlsson, Magnus <magnus.karlsson at intel.com>
> Subject: [Intel-wired-lan] [PATCH net] i40e: fix crash when Rx descriptor
> count is changed
> 
> From: Björn Töpel <bjorn.topel at intel.com>
> 
> When the AF_XDP buffer allocator was introduced, the Rx SW ring "rx_bi"
> allocation was moved from i40e_setup_rx_descriptors() function, and was
> instead done in the i40e_configure_rx_ring() function.
> 
> This broke the ethtool set_ringparam() hook for changing the Rx descriptor
> count, which was relying on i40e_setup_rx_descriptors() to handle the
> alloction.
> 
> Fix this by adding an explicit i40e_alloc_rx_bi() call to i40e_set_ringparam().
> 
> Fixes: be1222b585fd ("i40e: Separate kernel allocated rx_bi rings from
> AF_XDP rings")
> Signed-off-by: Björn Töpel <bjorn.topel at intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 +++
>  1 file changed, 3 insertions(+)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>





More information about the Intel-wired-lan mailing list