[Intel-wired-lan] [PATCH v1 1/1] igc: Remove TCP segmentation TX fail counter

[Brown, Aaron F]

> From: Neftin, Sasha <sasha.neftin at intel.com>
> Sent: Tuesday, June 23, 2020 8:22 PM
> To: Brown, Aaron F <aaron.f.brown at intel.com>; intel-wired-
> lan at lists.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove TCP segmentation
> TX fail counter
> 
> On 6/24/2020 04:15, Brown, Aaron F wrote:
> >
> >> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf
> Of
> >> Sasha Neftin
> >> Sent: Sunday, June 7, 2020 1:51 AM
> >> To: intel-wired-lan at lists.osuosl.org
> >> Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Remove TCP segmentation
> TX
> >> fail counter
> >>
> >> TCP segmentation TX context fail counter is not
> >> applicable for i225 devices.
> >> This patch comes to clean up this counter.
> >
> >
> > With this patch include I am seeing what appears to be the removed
> counter when I look at ethtool stats.
> > ----
> > u1322:[0]/usr/src/kernels/next-queue> ethtool -S eth1|grep seg
> >       tx_tcp_seg_good: 857
> >       tx_tcp_seg_failed: 0
> > u1322:[0]/usr/src/kernels/next-queue>
> > ----
> >
> > Does something need to be done to strip the counter display?  Or am I just
> looking at a similar counter.
> It is ok. You look at right counter exposed by ethtool. I've removed the
> "TCP Segmentation Context Tx" register not applicable to the i225 device.

Thanks for the explanation.

> >>
> >> Signed-off-by: Sasha Neftin <sasha.neftin at intel.com>
> >> ---
> >>   drivers/net/ethernet/intel/igc/igc_mac.c  | 1 -
> >>   drivers/net/ethernet/intel/igc/igc_main.c | 1 -
> >>   drivers/net/ethernet/intel/igc/igc_regs.h | 1 -
> >>   3 files changed, 3 deletions(-)
> >>
Tested-by: Aaron Brown<aaron.f.brown at intel.com>