[Intel-wired-lan] [PATCH v1 3/5] ixgbe: use generic power management
Bowers, AndrewX
andrewx.bowers at intel.com
Wed Jul 1 17:00:50 UTC 2020
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Vaibhav Gupta
> Sent: Monday, June 29, 2020 2:30 AM
> To: Bjorn Helgaas <helgaas at kernel.org>; Bjorn Helgaas
> <bhelgaas at google.com>; bjorn at helgaas.com; Vaibhav Gupta
> <vaibhav.varodek at gmail.com>; David S. Miller <davem at davemloft.net>;
> Jakub Kicinski <kuba at kernel.org>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher at intel.com>
> Cc: Vaibhav Gupta <vaibhavgupta40 at gmail.com>; netdev at vger.kernel.org;
> linux-kernel at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
> skhan at linuxfoundation.org; linux-kernel-
> mentees at lists.linuxfoundation.org
> Subject: [Intel-wired-lan] [PATCH v1 3/5] ixgbe: use generic power
> management
>
> With legacy PM hooks, it was the responsibility of a driver to manage PCI
> states and also the device's power state. The generic approach is to let PCI
> core handle the work.
>
> ixgbe_suspend() calls __ixgbe_shutdown() to perform intermediate tasks.
> __ixgbe_shutdown() modifies the value of "wake" (device should be
> wakeup enabled or not), responsible for controlling the flow of legacy PM.
>
> Since, PCI core has no idea about the value of "wake", new code for generic
> PM may produce unexpected results. Thus, use
> "device_set_wakeup_enable()"
> to wakeup-enable the device accordingly.
>
> Compile-tested only.
>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40 at gmail.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 61 +++++--------------
> 1 file changed, 15 insertions(+), 46 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers at intel.com>
More information about the Intel-wired-lan
mailing list