[Intel-wired-lan] [PATCH S50 02/15] ice: Fix link broken after GLOBR reset

Bowers, AndrewX andrewx.bowers at intel.com
Thu Jul 16 17:48:52 UTC 2020


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Monday, July 13, 2020 1:53 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S50 02/15] ice: Fix link broken after GLOBR
> reset
> 
> From: Dave Ertman <david.m.ertman at intel.com>
> 
> After a GLOBR, the link was broken so that a link up situation was being seen
> as a link down.
> 
> The problem was that the rebuild process was updating the port_info link
> status without doing any of the other things that need to be done when link
> changes.
> 
> This was causing the port_info struct to have current "UP" information so
> that any further UP interrupts were skipped as redundant.
> 
> The rebuild flow should *not* be updating the port_info struct link
> information, so eliminate this and leave it to the link event handling code.
> 
> Signed-off-by: Dave Ertman <david.m.ertman at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 4 ----
>  1 file changed, 4 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list