[Intel-wired-lan] [PATCH net-next] ice: mark PM functions as __maybe_unused

Bowers, AndrewX andrewx.bowers at intel.com
Wed Jul 29 17:14:46 UTC 2020


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Wei Yongjun
> Sent: Monday, July 27, 2020 6:42 PM
> To: Hulk Robot <hulkci at huawei.com>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher at intel.com>; Jakub Kicinski <kuba at kernel.org>; Alexei
> Starovoitov <ast at kernel.org>; Daniel Borkmann <daniel at iogearbox.net>;
> Jesper Dangaard Brouer <hawk at kernel.org>; John Fastabend
> <john.fastabend at gmail.com>; Abodunrin, Akeem G
> <akeem.g.abodunrin at intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; Wei Yongjun
> <weiyongjun1 at huawei.com>; netdev at vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ice: mark PM functions as
> __maybe_unused
> 
> In certain configurations without power management support, the following
> warnings happen:
> 
> drivers/net/ethernet/intel/ice/ice_main.c:4214:12: warning:
>  'ice_resume' defined but not used [-Wunused-function]
>  4214 | static int ice_resume(struct device *dev)
>       |            ^~~~~~~~~~
> drivers/net/ethernet/intel/ice/ice_main.c:4150:12: warning:
>  'ice_suspend' defined but not used [-Wunused-function]
>  4150 | static int ice_suspend(struct device *dev)
>       |            ^~~~~~~~~~~
> 
> Mark these functions as __maybe_unused to make it clear to the compiler
> that this is going to happen based on the configuration, which is the standard
> for these types of functions.
> 
> Fixes: 769c500dcc1e ("ice: Add advanced power mgmt for WoL")
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list