[Intel-wired-lan] [PATCH S51 01/13] ice: rename misleading grst_delay variable

Bowers, AndrewX andrewx.bowers at intel.com
Fri Jul 31 19:59:16 UTC 2020


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Wednesday, July 29, 2020 5:19 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S51 01/13] ice: rename misleading
> grst_delay variable
> 
> From: Nick Nunley <nicholas.d.nunley at intel.com>
> 
> The grst_delay variable in ice_check_reset contains the maximum time (in
> 100 msec units) that the driver will wait for a reset event to transition to the
> Device Active state. The value is the sum of three separate components:
> 1) The maximum time it may take for the firmware to process its outstanding
> command before handling the reset request.
> 2) The value in RSTCTL.GRSTDEL (the delay firmware inserts between first
> seeing the driver reset request and the actual hardware assertion).
> 3) The maximum expected reset processing time in hardware.
> 
> Referring to this total time as "grst_delay" is misleading and potentially
> confusing to someone checking the code and cross-referencing the
> hardware specification.
> 
> Fix this by renaming the variable to "grst_timeout", which is more descriptive
> of its actual use.
> 
> Signed-off-by: Nick Nunley <nicholas.d.nunley at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_common.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers at intel.com>




More information about the Intel-wired-lan mailing list