[Intel-wired-lan] [PATCH][v3] i40e: optimise prefetch page refcount

Brown, Aaron F aaron.f.brown at intel.com
Fri Sep 4 23:45:09 UTC 2020

> From: netdev-owner at vger.kernel.org <netdev-owner at vger.kernel.org>
> On Behalf Of Li RongQing
> Sent: Tuesday, August 18, 2020 12:08 AM
> To: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org
> Subject: [PATCH][v3] i40e: optimise prefetch page refcount
> refcount of rx_buffer page will be added here originally, so prefetchw
> is needed, but after commit 1793668c3b8c ("i40e/i40evf: Update code to
>  better handle incrementing page count"), and refcount is not added
> everytime, so change prefetchw as prefetch,
> now it mainly services page_address(), but which accesses struct page
> otherwise
> it returns address based on offset, so we prefetch it conditionally
> Jakub suggested to define prefetch_page_address in a common header
> Reported-by: kernel test robot <lkp at intel.com>
> Suggested-by: Jakub Kicinski <kuba at kernel.org>
> Signed-off-by: Li RongQing <lirongqing at baidu.com>
> ---
> diff with v2: fix a build warning -Wvisibility
> diff with v1: create a common function prefetch_page_address
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
>  include/linux/prefetch.h                    | 8 ++++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
Ignore my prior mail on the v2 for this patch.  I really was using v3.
Tested-by: Aaron Brown <aaron.f.brown at intel.com>

More information about the Intel-wired-lan mailing list