[Intel-wired-lan] [PATCH][next][v2] iavf: use kvzalloc instead of kzalloc for rx/tx_bi buffer

Jesse Brandeburg jesse.brandeburg at intel.com
Mon Sep 14 23:24:18 UTC 2020


Li RongQing wrote:

> when changes the rx/tx ring to 4096, kzalloc may fail due to
> a temporary shortage on slab entries.
> 
> so using kvmalloc to allocate this memory as there is no need
> that this memory area is physical continuously.
> 
> and using __GFP_RETRY_MAYFAIL to allocate from kmalloc as
> far as possible, which can reduce TLB pressure than vmalloc
> as suggested by Eric Dumazet

This change is no good, it's using RETRY_MAYFAIL but still using
v*alloc.

Please see my replies to the i40e version of the patch. I don't think
we should apply these.


More information about the Intel-wired-lan mailing list