[Intel-wired-lan] [patch 25/35] net: brcmfmac: Use netif_rx_any_context().
Thomas Gleixner
tglx at linutronix.de
Sun Sep 27 19:49:11 UTC 2020
From: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
The usage of in_interrupt() in non-core code is phased out. Ideally the
information of the calling context should be passed by the callers or the
functions be split as appropriate.
brcmfmac uses in_interupt() to select the netif_rx*() variant which matches
the calling context. The attempt to consolidate the code by passing an
arguemnt or by distangling it failed due lack of knowledge about this
driver and because the call chains are convoluted and hard to follow.
As a stop gap use netif_rx_any_context() which invokes the correct code
path depending on context which confines the usage of in_interrupt() to
core code.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
Cc: Arend van Spriel <arend.vanspriel at broadcom.com>
Cc: Franky Lin <franky.lin at broadcom.com>
Cc: Hante Meuleman <hante.meuleman at broadcom.com>
Cc: Kalle Valo <kvalo at codeaurora.org>
Cc: "David S. Miller" <davem at davemloft.net>
Cc: Jakub Kicinski <kuba at kernel.org>
Cc: linux-wireless at vger.kernel.org
Cc: brcm80211-dev-list.pdl at broadcom.com
Cc: brcm80211-dev-list at cypress.com
Cc: netdev at vger.kernel.org
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
@@ -418,14 +418,7 @@ void brcmf_netif_rx(struct brcmf_if *ifp
ifp->ndev->stats.rx_packets++;
brcmf_dbg(DATA, "rx proto=0x%X\n", ntohs(skb->protocol));
- if (in_interrupt())
- netif_rx(skb);
- else
- /* If the receive is not processed inside an ISR,
- * the softirqd must be woken explicitly to service
- * the NET_RX_SOFTIRQ. This is handled by netif_rx_ni().
- */
- netif_rx_ni(skb);
+ netif_rx_any_context(skb);
}
void brcmf_netif_mon_rx(struct brcmf_if *ifp, struct sk_buff *skb)
More information about the Intel-wired-lan
mailing list