[Intel-wired-lan] [PATCH v4 7/9] igc: Add initial XDP support
jesse.brandeburg at intel.com
Thu Nov 12 22:18:54 UTC 2020
Andre Guedes wrote:
> Quoting Neftin, Sasha (2020-11-12 01:13:27)
> > > +#define IGC_XDP_PASS 0
> > > +#define IGC_XDP_CONSUMED BIT(0)
> > > +
> > Hello Andre, please, move these defines to igc_defines.h to bottom the
> > file under /* XDP defines */ comment.
> Hi Sasha, looking at the macros defined in igc_defines.h, they seem to be
> hardware-related (registers, fields, masks, etc) which is not the case of
> the XDP macros defined here. In addition to that, note that these macros
> are used only in igc_main.c so maybe it makes sense to leave them here?
FWIW, I agree with Andre here, I'd just leave them in the igc_main.c
More information about the Intel-wired-lan