[Intel-wired-lan] [PATCH net-next v1 1/2] net: core: count drops from GRO

Eric Dumazet edumazet at google.com
Fri Jan 8 22:17:06 UTC 2021


On Fri, Jan 8, 2021 at 9:27 PM Saeed Mahameed <saeed at kernel.org> wrote:
>

> I think there is still some merit in this patchset even with Eric's
> removal of GRO_DROP from gro_receive(). As Eric explained, it is still
> possible to silently drop for the same reason when drivers
> call napi_get_frags or even alloc_skb() apis, many drivers do not
> account for such packet drops, and maybe it is the right thing to do to
> inline the packet drop accounting into the skb alloc APIs ? the
> question is, is it the job of those APIs to update netdev->stats ?
>

You absolutely do not want to have a generic increment of
netdev->stats for multiqueue drivers.
This would add terrible cache line false sharing under DDOS and memory stress.

Each driver maintains (or should maintain) per rx queue counter for this case.

It seems  mlx4 does nothing special, I would suggest you fix it :)


More information about the Intel-wired-lan mailing list