[Intel-wired-lan] [PATCH] igc: check return value of ret_val in igc_config_fc_after_link_up

Neftin, Sasha sasha.neftin at intel.com
Sat Jan 9 16:57:35 UTC 2021


On 1/7/2021 08:10, Kevin Lo wrote:
> Check return value from ret_val to make error check actually work.
> 
> Fixes: 4eb8080143a9 ("igc: Add setup link functionality")
> Signed-off-by: Kevin Lo <kevlo at kevlo.org>
> ---
> diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
> index 09cd0ec7ee87..67b8ffd21d8a 100644
> --- a/drivers/net/ethernet/intel/igc/igc_mac.c
> +++ b/drivers/net/ethernet/intel/igc/igc_mac.c
> @@ -638,7 +638,7 @@ s32 igc_config_fc_after_link_up(struct igc_hw *hw)
>   	}
>   
>   out:
> -	return 0;
> +	return ret_val;
>   }
>   
>   /**
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> 
Thanks for your patch.
Acked-by: Sasha Neftin <sasha.neftin at intel.com>


More information about the Intel-wired-lan mailing list