[Intel-wired-lan] [PATCH net v3] i40e: Fix for link-flapping

Jesse Brandeburg jesse.brandeburg at intel.com
Wed Jan 13 03:41:07 UTC 2021


Arkadiusz Kubalewski wrote:

> VF queues were not brought up when PF was brought up after being downed
> if the VF driver disabled VFs queues during PF down. This could happen
> in some older or external VF driver implementations.
> The problem was that PF driver used vf->queues_enabled as a condition
> to decide what link-state it would send out which caused the issue.
> Remove the check for vf->queues_enabled in the VF link notify. Now VF
> will always be notified of the current link status. Also remove
> the queues_enabled member from i40e_vf structure as it is not used
> anymore. Also refactor repeated link state reporting code into a
> separate helper function i40e_set_vf_link_state().
> Otherwise VNF implementation was broken and caused a link flap.
> 
> v2: improve commit message
> v3: net tree target

For future patches, please put vX: messages after a ---
which will allow git am to strip the vX: comments.  You can optionally
put the vX: messages in the same section as the diffstat info.

> 
> Fixes: 2ad1274fa35a ("i40e: don't report link up for a VF who hasn't
> enabled")

You probably don't need to wrap the Fixes line, but it probably
doesn't hurt either.

> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski at intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>

The patch sender's signoff should be last (think chronological order
starting with oldest at the top)


More information about the Intel-wired-lan mailing list