[Intel-wired-lan] [PATCH next-queue v1 2/2] igc: enable auxiliary PHC functions for the i225

[Nguyen, Anthony L]

On Mon, 2021-02-15 at 11:05 +0100, Paul Menzel wrote:
> Dear Ederson,
> 
> 
> Am 12.02.21 um 02:42 schrieb Ederson de Souza:
> > The i225 device offers a number of special PTP Hardware Clock
> > features on
> > the Software Defined Pins (SDPs). This patch adds support for two
> > of the
> > possible functions, namely time stamping external events, and
> > periodic
> > output signals.
> > 
> > The assignment of PHC functions to the four SDP can be freely
> > chosen by
> > the user.
> > 
> > While i225 allows up to four timers to be used to source the time
> > used
> > on the external events or output signals, this patch uses only one
> > of
> > those timers.
> 
> Why is that? Because it’s simpler to implement? Please add the reason
> to 
> the commit message.

I've applied this patch so testing can be done, but I agree with Paul.
Some detail on why only one timer is being used would be nice.

Also, there are quite a few check/warnings from checkpatch that look
like they can easily be remedied.

Thanks,
Tony