[Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising

[Neftin, Sasha]

On 2/19/2021 18:36, Muhammad Husaini Zulkifli wrote:
> Fix Pause Frame Advertising when getting the advertisement via ethtool.
> Remove setting the "advertising" bit in link_ksettings during default
> case when tx and rx are in off state with Auto Negotiatiate off.
> 
> Below is the original output of advertisement link during tx and rx off:
> Advertised pause frame use: Symmetric Receive-only
> 
> Expected output:
> Advertised pause frame use: No
> 
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli at intel.com>
> Reviewed-by: Malli C <mallikarjuna.chilakala at intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 824a6c454bca..67a4aed45fc2 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
>   						     Asym_Pause);
>   		break;
>   	default:
> -		ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> -		ethtool_link_ksettings_add_link_mode(cmd, advertising,
> -						     Asym_Pause);
> +		break;
>   	}
>   
>   	status = pm_runtime_suspended(&adapter->pdev->dev) ?
> 
Acked-by: Sasha Neftin <sasha.neftin at intel.com>