[Intel-wired-lan] [PATCH v1 1/1] igc: Remove no need includes from igc_mac.h

Nguyen, Anthony L anthony.l.nguyen at intel.com
Wed Feb 24 00:53:57 UTC 2021


On Tue, 2021-02-23 at 14:19 +0200, Sasha Neftin wrote:
> igc_defines.h and igc_phy.h included in igc_hw.h
> Therefore no need to include these headers in igc_mac.h
> where is include igc_hw.h

From the submit-checklist, we don't want to be relying on other files'
includes.

	If you use a facility then #include the file that
defines/declares
	that facility.  Don't depend on other header files pulling in
ones
	that you use.
	
https://www.kernel.org/doc/Documentation/process/submit-checklist.rst

Though we aren't perfect in this, we shouldn't be removing this as it's
desired.

Thanks,
Tony


More information about the Intel-wired-lan mailing list