[Intel-wired-lan] [PATCH net 13/13] ice: Cleanup fltr list in case of allocation issues

Tony Nguyen anthony.l.nguyen at intel.com
Fri Feb 26 21:19:32 UTC 2021

From: Robert Malz <robertx.malz at intel.com>

When ice_remove_vsi_lkup_fltr is called, by calling
ice_add_to_vsi_fltr_list local copy of vsi filter list
is created. If any issues during creation of vsi filter
list occurs it up for the caller to free already
allocated memory. This patch ensures proper memory
deallocation in these cases.

Fixes: 80d144c9ac82 ("ice: Refactor switch rule management structures and functions")
Signed-off-by: Robert Malz <robertx.malz at intel.com>
 drivers/net/ethernet/intel/ice/ice_switch.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 387d3f6cd71e..834cbd3f7b31 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -2624,7 +2624,7 @@ ice_remove_vsi_lkup_fltr(struct ice_hw *hw, u16 vsi_handle,
 	if (status)
-		return;
+		goto free_fltr_list;
 	switch (lkup) {
@@ -2647,6 +2647,7 @@ ice_remove_vsi_lkup_fltr(struct ice_hw *hw, u16 vsi_handle,
 	list_for_each_entry_safe(fm_entry, tmp, &remove_list_head, list_entry) {
 		devm_kfree(ice_hw_to_dev(hw), fm_entry);

More information about the Intel-wired-lan mailing list