[Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

Paul Menzel pmenzel at molgen.mpg.de
Fri Mar 5 09:03:58 UTC 2021


Dear Gustavo,


Thank you for working on that.

Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.

It would be nice to have a short summary of the discrepancy between GCC 
and clang, and it was decided to go with the “clang decision”, and not 
have clang adapt to GCC.

> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars at kernel.org>
> ---
>   drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> index 02b12736ea80..207f6ee3a7f6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> @@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
>   	case ICE_RX_PTYPE_INNER_PROT_UDP:
>   	case ICE_RX_PTYPE_INNER_PROT_SCTP:
>   		skb->ip_summed = CHECKSUM_UNNECESSARY;
> +		break;
>   	default:
>   		break;
>   	}


Kind regards,

Paul


More information about the Intel-wired-lan mailing list