[Intel-wired-lan] [PATCH S57 04/14] ice: Ignore EMODE return for opcode 0x0605

[Brelinski, TonyX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Thursday, March 25, 2021 3:35 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S57 04/14] ice: Ignore EMODE return for
> opcode 0x0605
> 
> From: Anirudh Venkataramanan <anirudh.venkataramanan at intel.com>
> 
> When link is owned by manageability, the driver is not allowed to fiddle with
> link. FW returns ICE_AQ_RC_EMODE if the driver attempts to do so.
> This patch adds a new function ice_set_link which abstracts the call to
> ice_aq_set_link_restart_an and provides a clean way to turn on/off link.
> 
> While making this change, I also spotted that an int variable was being used
> to hold both an ice_status return code and the Linux errno return code. This
> pattern more often than not results in the driver inadvertently returning
> ice_status back to kernel which is a major boo-boo. Clean it up.
> 
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 17 ++------
>  drivers/net/ethernet/intel/ice/ice_lib.c     | 37 ++++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_lib.h     |  2 +
>  drivers/net/ethernet/intel/ice/ice_main.c    | 41 ++++++++------------
>  4 files changed, 59 insertions(+), 38 deletions(-)

Tested-by: Tony Brelinski <tonyx.brelinski at intel.com> A Contingent Worker at Intel