[Intel-wired-lan] [PATCH S57 14/14] ice: Remove unnecessary checks in add/kill_vid ndo ops

Brelinski, TonyX tonyx.brelinski at intel.com
Wed Mar 31 21:58:45 UTC 2021


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Thursday, March 25, 2021 3:35 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S57 14/14] ice: Remove unnecessary
> checks in add/kill_vid ndo ops
> 
> From: Brett Creeley <brett.creeley at intel.com>
> 
> Currently the driver is doing two unnecessary checks. First both ops are
> checking if the VLAN ID passed in is less than VLAN_N_VID and second both
> ops are checking to see if a port VLAN is configured on the VSI.
> 
> The first check is already handled by the 8021q driver so this is an
> unnecessary check. The second check is unnecessary because the PF VSI is
> never put into a port VLAN.
> 
> Remove these checks.
> 
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 12 ------------
>  1 file changed, 12 deletions(-)

Tested-by: Tony Brelinski <tonyx.brelinski at intel.com> A Contingent Worker at Intel




More information about the Intel-wired-lan mailing list