[Intel-wired-lan] [PATCH net] i40e: Fix sparse errors in i40e_txrx.c

Switzer, David david.switzer at intel.com
Wed Apr 7 22:56:25 UTC 2021

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
>Arkadiusz Kubalewski
>Sent: Friday, March 26, 2021 11:44 AM
>To: intel-wired-lan at lists.osuosl.org
>Cc: Loktionov, Aleksandr <aleksandr.loktionov at intel.com>
>Subject: [Intel-wired-lan] [PATCH net] i40e: Fix sparse errors in i40e_txrx.c
>Remove error handling through pointers. Instead use plain int to return value
>from i40e_run_xdp(...).
>- sparse errors were produced during compilation:
>i40e_txrx.c:2338 i40e_run_xdp() error: (-2147483647) too low for ERR_PTR
>i40e_txrx.c:2558 i40e_clean_rx_irq() error: 'skb' dereferencing possible
>- sk_buff* was used to return value, but it has never had valid pointer to sk_buff.
>Returned value was always int handeled as a pointer.
>Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions")
>Fixes: 2e6893123830 ("i40e: split XDP_TX tail and XDP_REDIRECT map flushing")
>Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
>Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski at intel.com>
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Tested-by: Dave Switzer <david.switzer at intel.com>

More information about the Intel-wired-lan mailing list