[Intel-wired-lan] [net PATCH] ixgbe: Fix NULL pointer dereference in ethtool loopback test

Switzer, David david.switzer at intel.com
Fri Apr 9 19:39:20 UTC 2021


>-----Original Message-----
>From: Alexander Duyck <alexander.duyck at gmail.com>
>Sent: Monday, March 8, 2021 12:42 PM
>To: intel-wired-lan at lists.osuosl.org
>Cc: Brandeburg, Jesse <jesse.brandeburg at intel.com>; Nguyen, Anthony L
><anthony.l.nguyen at intel.com>; netdev at vger.kernel.org
>Subject: [net PATCH] ixgbe: Fix NULL pointer dereference in ethtool loopback test
>
>From: Alexander Duyck <alexanderduyck at fb.com>
>
>The ixgbe driver currently generates a NULL pointer dereference when
>performing the ethtool loopback test. This is due to the fact that there isn't a
>q_vector associated with the test ring when it is setup as interrupts are not
>normally added to the test rings.
>
>To address this I have added code that will check for a q_vector before returning
>a napi_id value. If a q_vector is not present it will return a value of 0.
>
>Fixes: b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path")
>Signed-off-by: Alexander Duyck <alexanderduyck at fb.com>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Tested-by: Dave Switzer <david.switzer at intel.com>



More information about the Intel-wired-lan mailing list