[Intel-wired-lan] [PATCH net-next v3 5/6] iavf: Support for modifying UDP RSS flow hashing
Jankowski, Konrad0
konrad0.jankowski at intel.com
Wed Apr 21 19:22:16 UTC 2021
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Haiyue Wang
> Sent: wtorek, 13 kwietnia 2021 02:49
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zhang, Qi Z <qi.z.zhang at intel.com>
> Subject: [Intel-wired-lan] [PATCH net-next v3 5/6] iavf: Support for
> modifying UDP RSS flow hashing
>
> Provides the ability to enable UDP RSS hashing by ethtool.
>
> It gives users option of generating RSS hash based on the UDP source and
> destination ports numbers, IPv4 or IPv6 source and destination addresses.
>
> Signed-off-by: Haiyue Wang <haiyue.wang at intel.com>
> ---
> .../net/ethernet/intel/iavf/iavf_adv_rss.c | 28 +++++++++++++++++--
> .../net/ethernet/intel/iavf/iavf_adv_rss.h | 10 ++++++-
> .../net/ethernet/intel/iavf/iavf_ethtool.c | 23 +++++++++++++--
> 3 files changed, 56 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_adv_rss.c
> b/drivers/net/ethernet/intel/iavf/iavf_adv_rss.c
> index 4c5771cdc445..a8e03aaccc6b 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_adv_rss.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_adv_rss.c
> @@ -56,6 +56,23 @@ iavf_fill_adv_rss_tcp_hdr(struct virtchnl_proto_hdr
> *hdr, u64 hash_flds)
> VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, TCP,
> DST_PORT); }
>
> +/**
> + * iavf_fill_adv_rss_udp_hdr - fill the UDP RSS protocol header
> + * @hdr: the virtchnl message protocol header data structure
> + * @hash_flds: the RSS configuration protocol hash fields */ static
> +void iavf_fill_adv_rss_udp_hdr(struct virtchnl_proto_hdr *hdr, u64
> +hash_flds) {
> + VIRTCHNL_SET_PROTO_HDR_TYPE(hdr, UDP);
> +
> + if (hash_flds & IAVF_ADV_RSS_HASH_FLD_UDP_SRC_PORT)
> + VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP,
> SRC_PORT);
> +
> + if (hash_flds & IAVF_ADV_RSS_HASH_FLD_UDP_DST_PORT)
> + VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, UDP,
> DST_PORT); }
> +
> /**
> * iavf_fill_adv_rss_cfg_msg - fill the RSS configuration into virtchnl message
> * @rss_cfg: the virtchnl message to be filled with RSS configuration setting
> @@ -92,6 +109,9 @@ iavf_fill_adv_rss_cfg_msg(struct virtchnl_rss_cfg
> *rss_cfg,
> case IAVF_ADV_RSS_FLOW_SEG_HDR_TCP:
> iavf_fill_adv_rss_tcp_hdr(hdr, hash_flds);
> break;
> + case IAVF_ADV_RSS_FLOW_SEG_HDR_UDP:
> + iavf_fill_adv_rss_udp_hdr(hdr, hash_flds);
> + break;
> default:
> return -EINVAL;
> }
> @@ -138,6 +158,8 @@ iavf_print_adv_rss_cfg(struct iavf_adapter *adapter,
> struct iavf_adv_rss *rss,
>
> if (packet_hdrs & IAVF_ADV_RSS_FLOW_SEG_HDR_TCP)
> proto = "TCP";
> + else if (packet_hdrs & IAVF_ADV_RSS_FLOW_SEG_HDR_UDP)
> + proto = "UDP";
> else
> return;
>
> @@ -155,9 +177,11 @@ iavf_print_adv_rss_cfg(struct iavf_adapter
> *adapter, struct iavf_adv_rss *rss,
> if (hash_flds & (IAVF_ADV_RSS_HASH_FLD_IPV4_DA |
> IAVF_ADV_RSS_HASH_FLD_IPV6_DA))
> strcat(hash_opt, "IP DA,");
> - if (hash_flds & IAVF_ADV_RSS_HASH_FLD_TCP_SRC_PORT)
> + if (hash_flds & (IAVF_ADV_RSS_HASH_FLD_TCP_SRC_PORT |
> + IAVF_ADV_RSS_HASH_FLD_UDP_SRC_PORT))
> strcat(hash_opt, "src port,");
> - if (hash_flds & IAVF_ADV_RSS_HASH_FLD_TCP_DST_PORT)
> + if (hash_flds & (IAVF_ADV_RSS_HASH_FLD_TCP_DST_PORT |
> + IAVF_ADV_RSS_HASH_FLD_UDP_DST_PORT))
> strcat(hash_opt, "dst port,");
>
> if (!action)
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_adv_rss.h
> b/drivers/net/ethernet/intel/iavf/iavf_adv_rss.h
> index 339ecb42938b..4681f5e8321d 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_adv_rss.h
> +++ b/drivers/net/ethernet/intel/iavf/iavf_adv_rss.h
> @@ -20,6 +20,7 @@ enum iavf_adv_rss_flow_seg_hdr {
> IAVF_ADV_RSS_FLOW_SEG_HDR_IPV4 = 0x00000001,
> IAVF_ADV_RSS_FLOW_SEG_HDR_IPV6 = 0x00000002,
> IAVF_ADV_RSS_FLOW_SEG_HDR_TCP = 0x00000004,
> + IAVF_ADV_RSS_FLOW_SEG_HDR_UDP = 0x00000008,
> };
>
> #define IAVF_ADV_RSS_FLOW_SEG_HDR_L3 \
> @@ -27,7 +28,8 @@ enum iavf_adv_rss_flow_seg_hdr {
> IAVF_ADV_RSS_FLOW_SEG_HDR_IPV6)
>
> #define IAVF_ADV_RSS_FLOW_SEG_HDR_L4 \
> - (IAVF_ADV_RSS_FLOW_SEG_HDR_TCP)
> + (IAVF_ADV_RSS_FLOW_SEG_HDR_TCP | \
> + IAVF_ADV_RSS_FLOW_SEG_HDR_UDP)
>
> enum iavf_adv_rss_flow_field {
> /* L3 */
> @@ -38,6 +40,8 @@ enum iavf_adv_rss_flow_field {
> /* L4 */
> IAVF_ADV_RSS_FLOW_FIELD_IDX_TCP_SRC_PORT,
> IAVF_ADV_RSS_FLOW_FIELD_IDX_TCP_DST_PORT,
> + IAVF_ADV_RSS_FLOW_FIELD_IDX_UDP_SRC_PORT,
> + IAVF_ADV_RSS_FLOW_FIELD_IDX_UDP_DST_PORT,
>
> /* The total number of enums must not exceed 64 */
> IAVF_ADV_RSS_FLOW_FIELD_IDX_MAX
> @@ -56,6 +60,10 @@ enum iavf_adv_rss_flow_field {
> BIT_ULL(IAVF_ADV_RSS_FLOW_FIELD_IDX_TCP_SRC_PORT)
> #define IAVF_ADV_RSS_HASH_FLD_TCP_DST_PORT \
> BIT_ULL(IAVF_ADV_RSS_FLOW_FIELD_IDX_TCP_DST_PORT)
> +#define IAVF_ADV_RSS_HASH_FLD_UDP_SRC_PORT \
> + BIT_ULL(IAVF_ADV_RSS_FLOW_FIELD_IDX_UDP_SRC_PORT)
> +#define IAVF_ADV_RSS_HASH_FLD_UDP_DST_PORT \
> + BIT_ULL(IAVF_ADV_RSS_FLOW_FIELD_IDX_UDP_DST_PORT)
>
> /* bookkeeping of advanced RSS configuration */ struct iavf_adv_rss { diff --
> git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> index b5ec8e723b61..8a396cba944b 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> @@ -1434,10 +1434,18 @@ static u32 iavf_adv_rss_parse_hdrs(struct
> ethtool_rxnfc *cmd)
> hdrs |= IAVF_ADV_RSS_FLOW_SEG_HDR_TCP |
> IAVF_ADV_RSS_FLOW_SEG_HDR_IPV4;
> break;
> + case UDP_V4_FLOW:
> + hdrs |= IAVF_ADV_RSS_FLOW_SEG_HDR_UDP |
> + IAVF_ADV_RSS_FLOW_SEG_HDR_IPV4;
> + break;
> case TCP_V6_FLOW:
> hdrs |= IAVF_ADV_RSS_FLOW_SEG_HDR_TCP |
> IAVF_ADV_RSS_FLOW_SEG_HDR_IPV6;
> break;
> + case UDP_V6_FLOW:
> + hdrs |= IAVF_ADV_RSS_FLOW_SEG_HDR_UDP |
> + IAVF_ADV_RSS_FLOW_SEG_HDR_IPV6;
> + break;
> default:
> break;
> }
> @@ -1459,12 +1467,14 @@ static u64 iavf_adv_rss_parse_hash_flds(struct
> ethtool_rxnfc *cmd)
> if (cmd->data & RXH_IP_SRC || cmd->data & RXH_IP_DST) {
> switch (cmd->flow_type) {
> case TCP_V4_FLOW:
> + case UDP_V4_FLOW:
> if (cmd->data & RXH_IP_SRC)
> hfld |= IAVF_ADV_RSS_HASH_FLD_IPV4_SA;
> if (cmd->data & RXH_IP_DST)
> hfld |= IAVF_ADV_RSS_HASH_FLD_IPV4_DA;
> break;
> case TCP_V6_FLOW:
> + case UDP_V6_FLOW:
> if (cmd->data & RXH_IP_SRC)
> hfld |= IAVF_ADV_RSS_HASH_FLD_IPV6_SA;
> if (cmd->data & RXH_IP_DST)
> @@ -1484,6 +1494,13 @@ static u64 iavf_adv_rss_parse_hash_flds(struct
> ethtool_rxnfc *cmd)
> if (cmd->data & RXH_L4_B_2_3)
> hfld |=
> IAVF_ADV_RSS_HASH_FLD_TCP_DST_PORT;
> break;
> + case UDP_V4_FLOW:
> + case UDP_V6_FLOW:
> + if (cmd->data & RXH_L4_B_0_1)
> + hfld |=
> IAVF_ADV_RSS_HASH_FLD_UDP_SRC_PORT;
> + if (cmd->data & RXH_L4_B_2_3)
> + hfld |=
> IAVF_ADV_RSS_HASH_FLD_UDP_DST_PORT;
> + break;
> default:
> break;
> }
> @@ -1617,10 +1634,12 @@ iavf_get_adv_rss_hash_opt(struct iavf_adapter
> *adapter,
> IAVF_ADV_RSS_HASH_FLD_IPV6_DA))
> cmd->data |= (u64)RXH_IP_DST;
>
> - if (hash_flds & IAVF_ADV_RSS_HASH_FLD_TCP_SRC_PORT)
> + if (hash_flds & (IAVF_ADV_RSS_HASH_FLD_TCP_SRC_PORT |
> + IAVF_ADV_RSS_HASH_FLD_UDP_SRC_PORT))
> cmd->data |= (u64)RXH_L4_B_0_1;
>
> - if (hash_flds & IAVF_ADV_RSS_HASH_FLD_TCP_DST_PORT)
> + if (hash_flds & (IAVF_ADV_RSS_HASH_FLD_TCP_DST_PORT |
> + IAVF_ADV_RSS_HASH_FLD_UDP_DST_PORT))
> cmd->data |= (u64)RXH_L4_B_2_3;
>
> return 0;
Tested-by: Konrad Jankowski <konrad0.jankowski at intel.com>
More information about the Intel-wired-lan
mailing list