[Intel-wired-lan] [net] igb: Check if num of q_vectors is smaller than max before array access.

Nguyen, Anthony L anthony.l.nguyen at intel.com
Wed Apr 21 23:04:48 UTC 2021


On Wed, 2021-04-21 at 15:15 +0000, Aleksandr Loktionov wrote:
> Ensure that the adapter->q_vector[MAX_Q_VECTORS] array isn't accessed
> beyond its size. It was fixed by using a local variable num_q_vectors
> as a limit for loop index, and ensure that num_q_vectors is not
> bigger
> than MAX_Q_VECTORS.
> 
> Fixes: 047e0030f1e6 ("igb: add new data structure for handling
> interrupts and NAPI")

As I mentioned in the last version, don't wrap the Fixes tag. It can go
over 75 char.

	Fixes tag: Fixes: 047e0030f1e6 ("igb: add new data structure
for handling
		Has these problem(s):
			- Subject has leading but no trailing 	parentheses
			- Subject has leading but no trailing quotes

Also, please remember to indicate revisions with change log when
resending. i.e. this should've been 'v2'. Can you fix the above and
resend as v3?

> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
> Reviewed-by: Grzegorz Siwik <grzegorz.siwik at intel.com>
> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski at intel.com>
> Reviewed-by: Slawomir Laba <slawomirx.laba at intel.com>
> Reviewed-by: Sylwester Dziedziuch <sylwesterx.dziedziuch at intel.com>
> Reviewed-by: Mateusz Palczewski <mateusz.placzewski at intel.com>
> ---


More information about the Intel-wired-lan mailing list