[Intel-wired-lan] [PATCH net-next v1] igb: Add counter to i21x doublecheck
Grzegorz Siwik
grzegorz.siwik at intel.com
Thu Apr 29 13:28:36 UTC 2021
Add failed_counter to i21x_doublecheck(). There is possibility that
loop will never end.
With this patch the loop will stop after maximum 3 retries
to write to MTA_REGISTER
Signed-off-by: Grzegorz Siwik <grzegorz.siwik at intel.com>
---
drivers/net/ethernet/intel/igb/e1000_mac.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_mac.c b/drivers/net/ethernet/intel/igb/e1000_mac.c
index e63ee3c..3cb7e55 100644
--- a/drivers/net/ethernet/intel/igb/e1000_mac.c
+++ b/drivers/net/ethernet/intel/igb/e1000_mac.c
@@ -492,6 +492,8 @@ static u32 igb_hash_mc_addr(struct e1000_hw *hw, u8 *mc_addr)
**/
static void igb_i21x_hw_doublecheck(struct e1000_hw *hw)
{
+ const unsigned int failed_cnt_max = 3;
+ unsigned int failed_cnt = 0;
bool is_failed;
int i;
@@ -502,10 +504,14 @@ static void igb_i21x_hw_doublecheck(struct e1000_hw *hw)
is_failed = true;
array_wr32(E1000_MTA, i, hw->mac.mta_shadow[i]);
wrfl();
- break;
}
}
- } while (is_failed);
+ if (is_failed)
+ ++failed_cnt;
+ } while (is_failed && failed_cnt < failed_cnt_max);
+
+ if (failed_cnt >= failed_cnt_max)
+ hw_dbg("Failed to update MTA_REGISTER, too many retries");
}
/**
--
1.8.3.1
More information about the Intel-wired-lan
mailing list