[Intel-wired-lan] [PATCH net 2/4] ice: report supported and advertised autoneg using PHY capabilities

Brelinski, TonyX tonyx.brelinski at intel.com
Wed May 12 15:44:33 UTC 2021


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Wednesday, May 5, 2021 2:18 PM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH net 2/4] ice: report supported and
> advertised autoneg using PHY capabilities
> 
> From: Paul Greenwalt <paul.greenwalt at intel.com>
> 
> Ethtool incorrectly reported supported and advertised auto-negotiation
> settings for a backplane PHY image which did not support auto-negotiation.
> This can occur when using media or PHY type for reporting ethtool supported
> and advertised auto-negotiation settings.
> 
> Remove setting supported and advertised auto-negotiation settings based
> on PHY type in ice_phy_type_to_ethtool(), and MAC type in
> ice_get_link_ksettings().
> 
> Ethtool supported and advertised auto-negotiation settings should be based
> on the PHY image using the AQ command get PHY capabilities with media.
> Add setting supported and advertised auto-negotiation settings based get
> PHY capabilities with media in ice_get_link_ksettings().
> 
> Fixes: 48cb27f2fd18 ("ice: Implement handlers for ethtool PHY/link
> operations")
> Signed-off-by: Paul Greenwalt <paul.greenwalt at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ethtool.c | 51 +++-----------------
>  1 file changed, 6 insertions(+), 45 deletions(-)

Tested-by: Tony Brelinski <tonyx.brelinski at intel.com> (A Contingent Worker at Intel)




More information about the Intel-wired-lan mailing list