[Intel-wired-lan] [PATCH next-queue v4 1/4] Revert "PCI: Make pci_enable_ptm() private"

Paul Menzel pmenzel at molgen.mpg.de
Sat Jun 5 05:47:23 UTC 2021


Dear Vinicius, dear Bjorn,


Am 05.06.21 um 01:27 schrieb Vinicius Costa Gomes:
> Bjorn Helgaas <helgaas at kernel.org> writes:
> 
>> On Fri, Jun 04, 2021 at 03:09:30PM -0700, Vinicius Costa Gomes wrote:

[…]

>>> Exposing this to the driver enables the driver to use the
>>> 'ptm_enabled' field of 'pci_dev' to check if PTM is enabled or not.
>>>
>>> This reverts commit ac6c26da29c12fa511c877c273ed5c939dc9e96c.
>>
>> Ideally I would cite this as ac6c26da29c1 ("PCI: Make pci_enable_ptm()
>> private") so there's a little more context.
> 
> Yeah, that looks better.
> 
> Will follow the suggestions you made in the next patch as well and send
> another version, thanks.

Just a note, that this is how revert commits are generated by `git 
revert` as the name of the reverted commit is in the commit message 
summary. Maybe just move the statement/sentence to the very top? But 
either way is fine.


Kind regards,

Paul


More information about the Intel-wired-lan mailing list