[Intel-wired-lan] [PATCH] igb: Avoid memcpy() over-reading of ETH_SS_STATS

Brelinski, TonyX tonyx.brelinski at intel.com
Fri Jun 25 22:41:37 UTC 2021


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Kees Cook
> Sent: Wednesday, June 16, 2021 12:53 PM
> To: netdev at vger.kernel.org
> Cc: Kees Cook <keescook at chromium.org>; linux-kernel at vger.kernel.org;
> linux-hardening at vger.kernel.org; Jakub Kicinski <kuba at kernel.org>; intel-
> wired-lan at lists.osuosl.org; David S. Miller <davem at davemloft.net>
> Subject: [Intel-wired-lan] [PATCH] igb: Avoid memcpy() over-reading of
> ETH_SS_STATS
> 
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally reading across neighboring array fields.
> 
> The memcpy() is copying the entire structure, not just the first array.
> Adjust the source argument so the compiler can do appropriate bounds
> checking.
> 
> Signed-off-by: Kees Cook <keescook at chromium.org>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Tested-by: Tony Brelinski <tonyx.brelinski at intel.com> (A Contingent Worker at Intel)




More information about the Intel-wired-lan mailing list