[Intel-wired-lan] [PATCH v1] igc: Increase timeout value for Speed 100/1000/2500

Zulkifli, Muhammad Husaini muhammad.husaini.zulkifli at intel.com
Wed Jul 14 01:41:54 UTC 2021

Thanks sasha and Vinicius!!

From: Neftin, Sasha <sasha.neftin at intel.com>
Sent: Wednesday, July 14, 2021 12:44 AM
To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli at intel.com>; intel-wired-lan at osuosl.org; Nguyen, Anthony L <anthony.l.nguyen at intel.com>; Gomes, Vinicius <vinicius.gomes at intel.com>
Subject: Re: [Intel-wired-lan] [PATCH v1] igc: Increase timeout value for Speed 100/1000/2500

On 7/10/2021 02:45, Muhammad Husaini Zulkifli wrote:

As the cycle time is set to maximum of 1s, the TX Hang timeout need to

be increase to avoid possible TX Hangs caused by using long Qbv cycles.

Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli at intel.com><mailto:muhammad.husaini.zulkifli at intel.com>


 drivers/net/ethernet/intel/igc/igc_main.c | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c

index c8abd7fb70e5..99fb5641297d 100644

--- a/drivers/net/ethernet/intel/igc/igc_main.c

+++ b/drivers/net/ethernet/intel/igc/igc_main.c

@@ -5322,7 +5322,9 @@ static void igc_watchdog_task(struct work_struct *work)

                               adapter->tx_timeout_factor = 14;


                        case SPEED_100:

-                              /* maybe add some timeout factor ? */

+                       case SPEED_1000:

+                       case SPEED_2500:

+                              adapter->tx_timeout_factor = 7;



Acked-by: Sasha Neftin <sasha.neftin at intel.com><mailto:sasha.neftin at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210714/c309837c/attachment-0001.html>

More information about the Intel-wired-lan mailing list