[Intel-wired-lan] [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies

Keller, Jacob E jacob.e.keller at intel.com
Mon Aug 2 21:09:19 UTC 2021



> -----Original Message-----
> From: Arnd Bergmann <arnd at kernel.org>
> Sent: Monday, August 02, 2021 1:59 PM
> To: Keller, Jacob E <jacob.e.keller at intel.com>
> Cc: Richard Cochran <richardcochran at gmail.com>; Nicolas Pitre
> <nicolas.pitre at linaro.org>; Brandeburg, Jesse <jesse.brandeburg at intel.com>;
> Nguyen, Anthony L <anthony.l.nguyen at intel.com>; David S. Miller
> <davem at davemloft.net>; Jakub Kicinski <kuba at kernel.org>; Arnd Bergmann
> <arnd at arndb.de>; Kurt Kanzenbach <kurt at linutronix.de>; Saleem, Shiraz
> <shiraz.saleem at intel.com>; Ertman, David M <david.m.ertman at intel.com>;
> intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; linux-
> kernel at vger.kernel.org
> Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
> dependencies
> 
> I don't want to mess with the semantics of the keyword any further.
> The original meaning was meant to avoid circular dependencies
> by making it a softer version of 'select' that would not try to select
> anything that has unmet dependencies. The current version made
> it even softer by only having an effect during 'make defconfig'
> and 'make oldconfig' but not preventing it from being soft-disabled
> any more. Changing it yet again is guarantee to break lots of the
> existing users, while probably also bringing back the original problem
> of the circular dependencies.
> 
>          Arnd

Yea ok that makes sense. Better to use a new keyword if we do at all.


More information about the Intel-wired-lan mailing list