[Intel-wired-lan] [PATCH net v2] i40e: Fix ATR queue selection

Switzer, David david.switzer at intel.com
Tue Aug 17 20:29:52 UTC 2021


>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
>Arkadiusz Kubalewski
>Sent: Thursday, July 22, 2021 8:20 AM
>To: intel-wired-lan at lists.osuosl.org
>Cc: Patynowski, PrzemyslawX <przemyslawx.patynowski at intel.com>
>Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix ATR queue selection
>
>Without this patch, ATR does not work. Receive/transmit uses queue
>selection based on SW DCB hashing method.
>
>If traffic classes are not configured for PF, then use netdev_pick_tx function
>for selecting queue for packet transmission.
>Instead of calling i40e_swdcb_skb_tx_hash, call netdev_pick_tx, which
>ensures that packet is transmitted/received from CPU that is running the
>application.
>
>Reproduction steps:
>1. Load i40e driver
>2. Map each MSI interrupt of i40e port for each CPU 3. Disable ntuple, enable
>ATR i.e.:
>ethtool -K $interface ntuple off
>ethtool --set-priv-flags $interface flow-director-atr 4. Run application that is
>generating traffic and is bound to a single CPU, i.e.:
>taskset -c 9 netperf -H 1.1.1.1 -t TCP_RR -l 10 5. Observe behavior:
>Application's traffic should be restricted to the CPU provided in taskset.
>
>Fixes: 821bd0c990ba ("i40e: Fix queue-to-TC mapping on Tx")
>Signed-off-by: Przemyslaw Patynowski
><przemyslawx.patynowski at intel.com>
>Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski at intel.com>
>---
>v2: Improved commit message
>---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Tested-by: Dave Switzer <david.switzer at intel.com> 



More information about the Intel-wired-lan mailing list