[Intel-wired-lan] [PATCH net v1] iavf: Fix refreshing iavf adapter stats on ethtool request

Paul Menzel pmenzel at molgen.mpg.de
Tue Sep 7 14:36:10 UTC 2021


Dear Jędrzej,


Am 07.09.21 um 14:54 schrieb Jagielski, Jedrzej:

> "Should the summary have a net prefix or so? Also shorter:
> 
>> iavf: Refresh iavf adapter stats on ethtool request"
> 
> Shouldn't the commit title begin begins with one from the words <fix/add/del/refactor>?

I am not aware of such a rule.

> "Should that be `iavf_schedule_request_stats()`?"
> This function is invoked only from iavf_get_ethtool_stats.

Reading the diff again, I am not sure how I missed that. Sorry for the 
noise.


Kind regards,

Paul


More information about the Intel-wired-lan mailing list