[Intel-wired-lan] [PATCH net-next] devlink: Make devlink_register to be void

Jakub Kicinski kuba at kernel.org
Mon Sep 20 21:04:07 UTC 2021

On Mon, 20 Sep 2021 13:39:15 -0700 Jakub Kicinski wrote:
> On Mon, 20 Sep 2021 17:41:44 +0300 Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro at nvidia.com>
> > 
> > devlink_register() can't fail and always returns success, but all drivers
> > are obligated to check returned status anyway. This adds a lot of boilerplate
> > code to handle impossible flow.
> > 
> > Make devlink_register() void and simplify the drivers that use that
> > API call.  
> Unlike unused functions bringing back error handling may be
> non-trivial. I'd rather you deferred such cleanups until you're 
> ready to post your full rework and therefore give us some confidence 
> the revert will not be needed.

If you disagree you gotta repost, new devlink_register call got added
in the meantime.

More information about the Intel-wired-lan mailing list