[Intel-wired-lan] [PATCH v2] ice: Add support to print error on PHY FW load failure

[Mekala, SunithaX D]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Brett Creeley
> Sent: Wednesday, October 13, 2021 9:02 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH v2] ice: Add support to print error on PHY FW load failure
>
> Some devices have support for loading the PHY FW and in some cases this can fail. When this fails, the FW will set the corresponding bit in the link info structure. Also, the FW will send a link event if the correct link event mask bit is set. Add support > for printing an error message when the PHY FW load fails during any link configuration flow and the link event flow.
>
> Since ice_check_module_power() is already doing something very similar add a new function ice_check_link_cfg_err() so any failures reported in the link info's link_cfg_err member can be printed in this one function.
>
> Also, add the new ICE_FLAG_PHY_FW_LOAD_FAILED bit to the PF's flags so we don't constantly print this error message during link polling if the value never changed.
>
> Signed-off-by: Brett Creeley <brett.creeley at intel.com>
> ---
> v2: Use correct bit for checking link_cfg_err
>
> drivers/net/ethernet/intel/ice/ice.h          |  1 +
> .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  2 +
>  drivers/net/ethernet/intel/ice/ice_main.c     | 49 +++++++++++++++++--
>  3 files changed, 47 insertions(+), 5 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mekala at intel.com> (A Contingent worker at Intel)