[Intel-wired-lan] [PATCH v1 1/1] igc: Remove unused phy type

Paul Menzel pmenzel at molgen.mpg.de
Mon Oct 25 09:28:31 UTC 2021


Dear Sasha,


On 25.10.21 09:16, Sasha Neftin wrote:

Please add `igc_phy_none` to the summary to be as specific as possible.

> _phy_none type not in use. Clean up the code accordingly,
> and get rid of the unused enum line

Please add a dot/period to the end of the sentence.

> Signed-off-by: Sasha Neftin <sasha.neftin at intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_hw.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h
> index 587db7483f25..76832e55cbbb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_hw.h
> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h
> @@ -55,7 +55,6 @@ enum igc_mac_type {
>   
>   enum igc_phy_type {
>   	igc_phy_unknown = 0,
> -	igc_phy_none,
>   	igc_phy_i225,
>   };

Reviewed-by: Paul Menzel <pmenzel at molgen.mpg.de>


Kind regards,

Paul


More information about the Intel-wired-lan mailing list