[Intel-wired-lan] [PATCH net v4] iavf: Fix displaying queue statistics shown by ethtool

Jankowski, Konrad0 konrad0.jankowski at intel.com
Wed Oct 27 09:43:53 UTC 2021



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Jedrzej Jagielski
> Sent: piątek, 17 września 2021 10:53
> To: intel-wired-lan at lists.osuosl.org
> Cc: Palczewski, Mateusz <mateusz.palczewski at intel.com>; Patynowski,
> PrzemyslawX <przemyslawx.patynowski at intel.com>; Witold Fijalkowski
> <witoldx.fijalkowski at intel.com>; Jagielski, Jedrzej
> <jedrzej.jagielski at intel.com>
> Subject: [Intel-wired-lan] [PATCH net v4] iavf: Fix displaying queue statistics
> shown by ethtool
> 
> Driver provided too many lines as an output to ethtool -S command.
> Return actual length of string set of ethtool stats. Instead of predefined
> maximal value use the actual value on netdev, iterate over active queues.
> Without this patch, ethtool -S report would produce additional erroneous
> lines.
> 
> Without this change in statistics after showing them by ethtool -S will be
> displayed queues that are not configured.
> 
> Fixes: 6dba41cd02fc ("i40evf: update ethtool stats code and use helper
> functions")
> Signed-off-by: Witold Fijalkowski <witoldx.fijalkowski at intel.com>
> Signed-off-by: Przemyslaw Patynowski
> <przemyslawx.patynowski at intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski at intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski at intel.com>
> ---
> V2: Fix commit message
> V3: Squash patch 5d12f51b9820 ("iavf: Fix ethtool -S output")
> V4: Remove one blank line
> 
>  .../net/ethernet/intel/iavf/iavf_ethtool.c    | 30 ++++++++++++-------
>  1 file changed, 19 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> index 7cbe59beeebb..014db92d33be 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> @@ -331,9 +331,16 @@ static int iavf_get_link_ksettings(struct net_device
> *netdev,
>   **/

Tested-by: Konrad Jankowski <konrad0.jankowski at intel.com>


More information about the Intel-wired-lan mailing list