[Intel-wired-lan] [PATCH bpf-next v2] net: don't include filter.h from net/sock.h
Florian Fainelli
f.fainelli at gmail.com
Wed Dec 29 01:33:39 UTC 2021
On 12/28/2021 4:49 PM, Jakub Kicinski wrote:
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
>
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
>
> Acked-by: Marc Kleine-Budde <mkl at pengutronix.de>
> Signed-off-by: Jakub Kicinski <kuba at kernel.org>
Acked-by: Florian Fainelli <f.fainelli at gmail.com>
It would be nice if we used the number of files rebuilt because of a
header file change as another metric that the kernel is evaluated with
from release to release (or even on a commit by commit basis). Food for
thought.
--
Florian
More information about the Intel-wired-lan
mailing list